My changes work with latest Raspberry Pi OS Debian 13 Trixie

[Pintjebier]

Made changes so the Fanshim is working again with Raspberry Pi OS Debian 13 Trixie

[headbank]

Hi, I'd like to try this out - could you please instruct a git-novice how to do so?

What I attempted:

$ git clone https://github.com/pimoroni/fanshim-python
$ wget https://github.com/pimoroni/fanshim-python/pull/121.patch
$ cd fanshim-python
$ git apply --status ../121.patch
$ git apply --check ../121.patch
$ git apply ../121.patch
$ ./install.sh

But I am seeing the same failure and error output as I got with the unpatched dist. (can supply if that helps) so assume I've done something wrong. Thanks

[Pintjebier]

Hi, I'd like to try this out - could you please instruct a git-novice how to do so?

What I attempted:

$ git clone https://github.com/pimoroni/fanshim-python
$ wget https://github.com/pimoroni/fanshim-python/pull/121.patch
$ cd fanshim-python
$ git apply --status ../121.patch
$ git apply --check ../121.patch
$ git apply ../121.patch
$ ./install.sh

But I am seeing the same failure and error output as I got with the unpatched dist. (can supply if that helps) so assume I've done something wrong. Thanks

I don't think you are doing anything wrong here. You need to run the script as sudo though.

[headbank]

Yep, that sequence was done all as root, should have said (I'm lazy...)

It's a dirty install (upgraded in-place twice now) so maybe some system cruft is causing Python issues. I'll start over and see if it works on a clean install.

BTW I noticed you removed the cli short options; anything other behavioural changes to be aware of with this patch? (I'm not really python conversant but I did make some minor tweaks to button behaviour in the stock version's script)

UPDATE: Works a treat on a clean install. Sorry for the noise and many thanks, hope the maintainers pick this up or match it soon!

[Pintjebier]

Yep, that sequence was done all as root, should have said (I'm lazy...)

It's a dirty install (upgraded in-place twice now) so maybe some system cruft is causing Python issues. I'll start over and see if it works on a clean install.

BTW I noticed you removed the cli short options; anything other behavioural changes to be aware of with this patch? (I'm not really python conversant but I did make some minor tweaks to button behaviour in the stock version's script)

UPDATE: Works a treat on a clean install. Sorry for the noise and many thanks, hope the maintainers pick this up or match it soon!

I hope this too. Noticed that the colors of the LED don't work whatever I try.