Skip to content

Implement scan_factor and max_candidates for query#138

Merged
austin-denoble merged 2 commits intomainfrom
adenoble/new-byoc-query-knobs
Feb 19, 2026
Merged

Implement scan_factor and max_candidates for query#138
austin-denoble merged 2 commits intomainfrom
adenoble/new-byoc-query-knobs

Conversation

@austin-denoble
Copy link
Copy Markdown
Contributor

@austin-denoble austin-denoble commented Feb 18, 2026

Problem

There are new parameters available on query for indexes with dedicated read nodes:

  • scan_factor
  • max_candidates

These were pulled into the 2025-10 API release and need to be added to the clients.

Solution

  • Regenerate core off 2025-10 to pull in scan_factor and max_candidates.
  • Add ScanFactor and MaxCandidates to QueryByVectorValuesRequest and QueryByVectorIdRequest, and wire through in IndexConnection.QueryByVectorValues and IndexConnection.QueryByVectorId.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

CI - unit and integration tests


Note

Low Risk
Mostly additive, generated API surface changes plus simple request-field plumbing; low risk aside from potential client-side expectation changes around optional query parameters.

Overview
Adds two new optional query tuning parameters—scan_factor and max_candidates—to the 2025-10 generated gRPC and REST models (QueryRequest), including accessors/oneof metadata.

Extends IndexConnection query request types (QueryByVectorValuesRequest, QueryByVectorIdRequest) to accept these options and forwards them into the underlying db_data_grpc.QueryRequest, enabling DRN-specific recall/latency tuning without changing existing call patterns.

Written by Cursor Bugbot for commit 1937fcd. This will update automatically on new commits. Configure here.

@austin-denoble austin-denoble merged commit a5c7d00 into main Feb 19, 2026
6 checks passed
@austin-denoble austin-denoble deleted the adenoble/new-byoc-query-knobs branch February 19, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant