Implement scan_factor and max_candidates for query#138
Merged
austin-denoble merged 2 commits intomainfrom Feb 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There are new parameters available on
queryfor indexes with dedicated read nodes:scan_factormax_candidatesThese were pulled into the
2025-10API release and need to be added to the clients.Solution
2025-10to pull inscan_factorandmax_candidates.ScanFactorandMaxCandidatestoQueryByVectorValuesRequestandQueryByVectorIdRequest, and wire through inIndexConnection.QueryByVectorValuesandIndexConnection.QueryByVectorId.Type of Change
Test Plan
CI - unit and integration tests
Note
Low Risk
Mostly additive, generated API surface changes plus simple request-field plumbing; low risk aside from potential client-side expectation changes around optional query parameters.
Overview
Adds two new optional query tuning parameters—
scan_factorandmax_candidates—to the2025-10generated gRPC and REST models (QueryRequest), including accessors/oneof metadata.Extends
IndexConnectionquery request types (QueryByVectorValuesRequest,QueryByVectorIdRequest) to accept these options and forwards them into the underlyingdb_data_grpc.QueryRequest, enabling DRN-specific recall/latency tuning without changing existing call patterns.Written by Cursor Bugbot for commit 1937fcd. This will update automatically on new commits. Configure here.