Add BM25Encoder.update() which updates encoder values with new documents#75
Open
adrwz wants to merge 1 commit intopinecone-io:mainfrom
Open
Add BM25Encoder.update() which updates encoder values with new documents#75adrwz wants to merge 1 commit intopinecone-io:mainfrom
adrwz wants to merge 1 commit intopinecone-io:mainfrom
Conversation
If we want to use this BM25Encoder in production & host it somewhere (or save it to a .pkl), there's no way to update it with new documents. Adding that function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If we want to use this BM25Encoder in production & host it somewhere (or save it to a .pkl), there's no way to update it with new documents.
Solution
Wrote update() to update the BM25 encoder with documents.
Type of Change
Test Plan
Run update()