Added optional input "model_dir" to class SpladeEncoder#79
Open
Grecil wants to merge 3 commits intopinecone-io:mainfrom
Open
Added optional input "model_dir" to class SpladeEncoder#79Grecil wants to merge 3 commits intopinecone-io:mainfrom
Grecil wants to merge 3 commits intopinecone-io:mainfrom
Conversation
…hould be downloaded in or loaded from. This saves a lot of time, memory and network resources.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Everytime an object of this class is initialise, the model is downloaded again. This wastes time, memory and network resources
Solution
Added optional input "model_dir" to specify the directory model should be downloaded in and loaded from.
Type of Change
Test Plan
Describe specific steps for validating this change.