Add index pointer of each token within doc_freq#80
Open
eramirem wants to merge 1 commit intopinecone-io:mainfrom
Open
Add index pointer of each token within doc_freq#80eramirem wants to merge 1 commit intopinecone-io:mainfrom
eramirem wants to merge 1 commit intopinecone-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If we want to use the output of
BM25Encoder._encode_single_documentto form ascipy.sparsearray, we cannot use the mmh3 hashes returned asindices, but we rather need the positions of the non-null keywords within the document frequency object.Solution
Add a flag to specify whether you want the index positions to be returned by
_encode_single_documentType of Change
Test Plan
Describe specific steps for validating this change.