Skip to content

system-variables: add optimizer cost factors#20667

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
Oreoxmt:translate/docs-20748
Aug 14, 2025
Merged

system-variables: add optimizer cost factors#20667
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
Oreoxmt:translate/docs-20748

Conversation

@Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Jul 16, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Documented all of the new optimizer cost factors.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt self-assigned this Jul 16, 2025
@Oreoxmt Oreoxmt added translation/from-docs This PR is translated from a PR in pingcap/docs. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2. labels Jul 16, 2025
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 16, 2025
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Jul 16, 2025

/cc @lilin90

@ti-chi-bot ti-chi-bot bot requested a review from lilin90 July 16, 2025 03:49
@lilin90 lilin90 changed the title planner: add optimizer cost factors system-variables: add optimizer cost factors Jul 17, 2025
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 13, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-13 08:36:43.934083557 +0000 UTC m=+429402.968666785: ☑️ agreed by lilin90.

@Oreoxmt Oreoxmt added the lgtm label Aug 13, 2025
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Aug 14, 2025

/unhold

@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Aug 14, 2025

/approve

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 14, 2025
@ti-chi-bot ti-chi-bot bot merged commit 3b5e36e into pingcap:master Aug 14, 2025
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20781.

@Oreoxmt Oreoxmt deleted the translate/docs-20748 branch August 14, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants