Skip to content

br: add unrecoverable system tables list - #20145

Merged
ti-chi-bot[bot] merged 7 commits into
pingcap:masterfrom
Leavrth:update_global_checkpoint_ts_for_safepoint
Mar 21, 2025
Merged

br: add unrecoverable system tables list#20145
ti-chi-bot[bot] merged 7 commits into
pingcap:masterfrom
Leavrth:update_global_checkpoint_ts_for_safepoint

Conversation

@Leavrth

@Leavrth Leavrth commented Jan 26, 2025

Copy link
Copy Markdown
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2025
@Oreoxmt Oreoxmt self-assigned this Feb 10, 2025
@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. for-release This PR relates to a TiDB release but does not have a tracked feature. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. labels Feb 10, 2025
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Feb 10, 2025
@Oreoxmt
Oreoxmt self-requested a review February 10, 2025 07:15
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot

ti-chi-bot Bot commented Mar 3, 2025

Copy link
Copy Markdown

@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 6, 2025
@Oreoxmt

Oreoxmt commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

/cc @qiancai

@ti-chi-bot
ti-chi-bot Bot requested a review from qiancai March 6, 2025 08:50

@qiancai qiancai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread br/br-snapshot-guide.md Outdated
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 10, 2025
@ti-chi-bot

ti-chi-bot Bot commented Mar 10, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-03-06 07:45:25.642184246 +0000 UTC m=+514038.771103991: ☑️ agreed by Oreoxmt.
  • 2025-03-10 03:01:24.493175317 +0000 UTC m=+152040.098704244: ☑️ agreed by qiancai.

Oreoxmt and others added 4 commits March 10, 2025 11:23
Co-authored-by: Grace Cai <qqzczy@126.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@Oreoxmt

Oreoxmt commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

/approve

@Oreoxmt

Oreoxmt commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

/unhold

@ti-chi-bot

ti-chi-bot Bot commented Mar 21, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2025
@ti-chi-bot ti-chi-bot Bot added the approved label Mar 21, 2025
@ti-chi-bot
ti-chi-bot Bot merged commit e3c528f into pingcap:master Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants