kafka: avoid create changefeed failures if can't get a topic from broker (#5696) - #5810
kafka: avoid create changefeed failures if can't get a topic from broker (#5696)#5810ti-chi-bot wants to merge 2 commits into
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@wk989898 This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Cherry-pick conflicts appear resolved; removing the |
|
Fixed by #5772 |
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #5696
What problem does this PR solve?
Issue Number: close #5563
What is changed and how it works?
If ticdc can't get the topic from kafka broker, still create a changefeed instead of throwing an error.
Check List
Tests
changefeed createresultmaster1ErrChangeFeedNotExistsCreateTopicAndWaitUntilVisibletreated the topic as unavailable and attemptedCreateTopic; Kafka returned Topic authorization failure1ErrChangeFeedNotExistsbin/cdcfromacl-0720 @ 6225925f; this run did not use the modifieddownstreamadapterimplementationcdc server --newarch0state: normalstate: warning,ErrKafkaSendMessageafter DDLdownstreamadapterimplementation; create passed by skipping topic creation after authorization failure, but runtime write still requires TopicWriteQuestions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Summary by CodeRabbit