kafka: share one claimcheck instance across encoders (#5718) - #5812
kafka: share one claimcheck instance across encoders (#5718)#5812ti-chi-bot wants to merge 1 commit into
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@3AceShowHand This PR has conflicts, I have hold it. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
close by #5811 |
This is an automated cherry-pick of #5718
What problem does this PR solve?
When Kafka claim-check handling is enabled, every event encoder creates its own
ClaimCheckand external storage client. Because an encoder group contains multiple encoders, the number of storage clients grows with encoder concurrency even though they all use the same configuration and storage URI.Issue Number: close #5719
What is changed and how it works?
ClaimCheckat the Kafka sink component level.Pulsar does not enable claim-check handling and continues to pass no
ClaimCheckto its encoders.Check List
Tests
Unit test
Questions
Will it cause performance regression or break compatibility?
It reduces external storage client and connection usage when Kafka claim-check is enabled. It changes exported Go encoder constructor signatures to accept a sink-owned
ClaimCheck, but does not change sink configuration, encoded message formats, or runtime protocol compatibility.Do you need to update user documentation, design documentation or monitoring documentation?
No user-facing documentation or monitoring changes are required because configuration and behavior remain unchanged.
Release note
Summary by CodeRabbit
New Features
Bug Fixes
Tests