kafka: create and wait for topic during verification (#5898) - #5906
kafka: create and wait for topic during verification (#5898)#5906ti-chi-bot wants to merge 4 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
duplicate of https://github.com/pingcap/ticdc/pull/5897,close it |
This is an automated cherry-pick of #5898
What problem does this PR solve?
Issue Number: close #5896
What is changed and how it works?
When a Kafka consumer starts immediately after a changefeed is created, it can auto-create the topic with the broker defaults before TiCDC initializes the Kafka sink. Kafka sink verification previously sent a validate-only
CreateTopicsrequest, so the topic was not actually created. This can leave the topic with a partition count different from the changefeed configuration, causing message delivery failures and increasing replication lag.What is changed and how it works?
CreateTopicoperation always create the topic. The Sarama adapter now owns the fixedvalidateOnly=falseargument.Check List
Tests
Unit test
go test --tags=intest ./downstreamadapter/sink/topicmanager \ ./downstreamadapter/sink/kafka ./pkg/sink/kafka -count=1Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes