event: account for raw rows in batch DML event size - #5960
Conversation
Remote batch DML events retain their row payload in RawRows until the event collector handles them. Include that payload in GetSize so dynamic stream memory and byte batching account for it.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesRemote Batch DML size accounting
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #5959
Remote
BatchDMLEventinstances keep their encoded row payload inRawRowsuntil the event collector calls
AssembleRows.GetSizeonly accounted forRows, so dynamic stream memory control and byte-based batching treated theremote row payload as zero bytes.
What is changed and how it works?
Make
BatchDMLEvent.GetSizereturn the encodedRawRowslength before rowsare assembled. After assembly, it continues to return the decoded chunk's
memory usage.
Extend the existing remote-row assembly unit test to verify size accounting
before serialization, after remote deserialization, and after row assembly.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No compatibility impact. Remote batches may be split earlier when their actual
payload reaches the configured byte threshold, which is the intended behavior.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note
Summary by CodeRabbit