Skip to content

kafka: decouple topic manager tests from Sarama #5961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3AceShowHand wants to merge 4 commits into
base: master
Choose a base branch
from
Open

kafka: decouple topic manager tests from Sarama #5961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b42707
first commit
3AceShowHand Aug 12, 2026
0b7df28
adjust code
3AceShowHand Aug 12, 2026
427e92f
Merge branch 'master' into topic-manager-decouple-sarama
3AceShowHand Aug 13, 2026
2b3c99e
adjust code
3AceShowHand Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions downstreamadapter/sink/topicmanager/kafka_topic_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ func (m *kafkaTopicManager) CreateTopicAndWaitUntilVisible(
// which means we should create the topic later.
topicDetails, err := m.admin.GetTopicsMeta([]string{topicName}, true)
if err != nil {
if kafka.IsAdminAuthorizationFailed(err) {
if kafka.IsAuthorizationFailed(err) {
return m.useConfiguredPartitionNum(topicName, err), nil
}
return 0, err
Expand All @@ -288,7 +288,7 @@ func (m *kafkaTopicManager) CreateTopicAndWaitUntilVisible(

topicDetails, err = m.admin.GetTopicsMeta([]string{topicName}, false)
if err != nil {
if kafka.IsAdminAuthorizationFailed(err) {
if kafka.IsAuthorizationFailed(err) {
return m.useConfiguredPartitionNum(topicName, err), nil
}
} else if numPartition, ok := m.tryStoreTopicMeta(topicName, topicDetails); ok {
Expand All @@ -298,7 +298,7 @@ func (m *kafkaTopicManager) CreateTopicAndWaitUntilVisible(
start := time.Now()
partitionNum, err := m.createTopic(ctx, topicName)
if err != nil {
if kafka.IsAdminAuthorizationFailed(err) {
if kafka.IsAuthorizationFailed(err) {
return m.useConfiguredPartitionNum(topicName, err), nil
}
return 0, err
Expand Down
Loading
Loading