test by hongyunyan · Pull Request #12511 · pingcap/tiflow

hongyunyan · 2026-02-02T12:40:12Z

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

ti-chi-bot · 2026-02-02T12:40:20Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 3pointer for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gemini-code-assist · 2026-02-02T12:40:23Z

Summary of Changes

Hello @hongyunyan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request appears to be a test or placeholder, as indicated by its generic title "test" and the minimal code change. The only modification is the addition of an empty comment line within a Go source file, which has no functional impact on the codebase.

Highlights

Code Comment: An empty comment line was added below an existing comment in the multiStmtExecute function within cdc/sink/dmlsink/txn/mysql/mysql.go.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a minor formatting change, adding a trailing whitespace and an empty comment line. My review suggests removing this change to maintain code cleanliness. Overall, the change is trivial.

gemini-code-assist · 2026-02-02T12:46:35Z

cdc/sink/dmlsink/txn/mysql/mysql.go

+// execute SQLs in the multi statements way. 
+// 


The trailing whitespace and the empty comment line are unnecessary. Please remove them to keep the code clean. An empty comment line // is different from a blank line and should be avoided if it doesn't contain any text.

Suggested change

// execute SQLs in the multi statements way.

//

// execute SQLs in the multi statements way.

ti-chi-bot · 2026-02-02T13:07:40Z

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

_{📖 For more info, you can check the "Contribute Code" section in the development guide.}

codecov · 2026-02-02T13:26:46Z

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
4181	2	4179	5

View the top 3 failed test(s) by shortest run time

github.com/pingcap/tiflow/dm/simulator/mcp::TestMCPSuite/TestMCPAddDeleteBasic

Stack Traces | 0.05s run time

=== RUN   TestMCPSuite/TestMCPAddDeleteBasic
    mcp_test.go:133: new added UK: 0xc00077ec00: { RowID: 4096, Keys: ( id = 373095544022806436; ) }
    mcp_test.go:133: new added UK: 0xc00077ecf0: { RowID: 4097, Keys: ( id = 6108796562867539966; ) }
    mcp_test.go:133: new added UK: 0xc00077edb0: { RowID: 4098, Keys: ( id = 4365885100952145741; ) }
    mcp_test.go:133: new added UK: 0xc00077ee40: { RowID: 4099, Keys: ( id = 681999435078350700; ) }
    mcp_test.go:133: new added UK: 0xc00077eed0: { RowID: 4100, Keys: ( id = 6424603494713269844; ) }
    mcp_test.go:156: new UK after delete on the index 0: 0xc00077ea80: { RowID: 0, Keys: ( id = 4095; ) }
    mcp_test.go:156: new UK after delete on the index 1: 0xc00077ea20: { RowID: 1, Keys: ( id = 4094; ) }
    mcp_test.go:156: new UK after delete on the index 2: 0xc00077e9c0: { RowID: 2, Keys: ( id = 4093; ) }
    mcp_test.go:156: new UK after delete on the index 3: 0xc00077e960: { RowID: 3, Keys: ( id = 4092; ) }
    mcp_test.go:156: new UK after delete on the index 4: 0xc00077e900: { RowID: 4, Keys: ( id = 4091; ) }
    mcp_test.go:170: new UK after delete on the index 4089: 0xc00077e8a0: { RowID: 4089, Keys: ( id = 4090; ) }
    mcp_test.go:169: 
        	Error Trace:	.../simulator/mcp/mcp_test.go:169
        	Error:      	Not equal: 
        	            	expected: 4089
        	            	actual  : 4090
        	Test:       	TestMCPSuite/TestMCPAddDeleteBasic
        	Messages:   	the swapped UK's value is abnormal
    mcp_test.go:170: new UK after delete on the index 1724: 0xc00077e8a0: { RowID: 1724, Keys: ( id = 4090; ) }
    mcp_test.go:170: new UK after delete on the index 1451: 0xc00077e7e0: { RowID: 1451, Keys: ( id = 4088; ) }
    mcp_test.go:170: new UK after delete on the index 1143: 0xc00077e780: { RowID: 1143, Keys: ( id = 4087; ) }
    mcp_test.go:170: new UK after delete on the index 2765: 0xc00077e720: { RowID: 2765, Keys: ( id = 4086; ) }
    --- FAIL: TestMCPSuite/TestMCPAddDeleteBasic (0.05s)

github.com/pingcap/tiflow/dm/simulator/mcp::TestMCPSuite

Stack Traces | 0.09s run time

=== RUN   TestMCPSuite
--- FAIL: TestMCPSuite (0.09s)

github.com/pingcap/tiflow/engine/executor/dm::TestWorker

Stack Traces | 1.68s run time

=== RUN   TestWorker
[2026/02/02 22:39:50.013 +08:00] [INFO] [broker.go:104] ["Create new resource broker"] [executor-id=executor-1] [config="{\"local\":{\"base-dir\":\"/tmp/2215801019-localfiles\"},\"s3\":{\"endpoint\":\"\",\"region\":\"\",\"storage-class\":\"\",\"sse\":\"\",\"sse-kms-key-id\":\"\",\"acl\":\"\",\"access-key\":\"\",\"secret-access-key\":\"\",\"session-token\":\"\",\"provider\":\"\",\"force-path-style\":false,\"use-accelerate-endpoint\":false,\"role-arn\":\"\",\"external-id\":\"\",\"profile\":\"\",\"object-lock-enabled\":false,\"bucket\":\"\",\"prefix\":\"\"},\"gcs\":{\"endpoint\":\"\",\"storage-class\":\"\",\"predefined-acl\":\"\",\"credentials-file\":\"\",\"bucket\":\"\",\"prefix\":\"\"}}"]
[2026/02/02 22:39:50.014 +08:00] [INFO] [broker.go:133] ["broker will not use s3/gcs as external storage since s3/gcs are both not configured"]
[2026/02/02 22:39:50.024 +08:00] [INFO] [worker.go:149] ["initializing the dm worker"] [job_id=master-id] [worker_id=worker-id] [task-id=task-id]
[2026/02/02 22:39:50.028 +08:00] [INFO] [worker.go:252] ["task stage changed"] [job_id=master-id] [worker_id=worker-id] [task-id=task-id] [from=Initing] [to=Running]
[2026/02/02 22:39:50.029 +08:00] [INFO] [worker.go:257] ["update status"] [job_id=master-id] [worker_id=worker-id] [task-id=task-id] [status="{\"Unit\":\"DMDumpTask\",\"Task\":\"task-id\",\"Stage\":\"Running\",\"CfgModRevision\":0,\"StageUpdatedTime\":\"2026-02-02T22:39:50.029076137+08:00\"}"]
[2026/02/02 22:39:50.030 +08:00] [ERROR] [worker.go:356] ["task runs with error"] [job_id=master-id] [worker_id=worker-id] [task-id=task-id] ["error msg"="[{}]"] [stack="github..../engine/executor/dm.(*dmWorker).checkAndAutoResume\n\.../executor/dm/worker.go:356\ngithub..../engine/executor/dm.(*dmWorker).Tick\n\.../executor/dm/worker.go:174\ngithub..../engine/executor/dm.TestWorker\n\.../executor/dm/worker_test.go:143\ntesting.tRunner\n\.../src/testing/testing.go:1934"]
[2026/02/02 22:39:50.030 +08:00] [INFO] [worker.go:357] ["got auto resume strategy"] [job_id=master-id] [worker_id=worker-id] [task-id=task-id] [strategy="dispatch auto resume"]
[2026/02/02 22:39:50.030 +08:00] [INFO] [worker.go:361] ["dispatch auto resume task"] [job_id=master-id] [worker_id=worker-id] [task-id=task-id]
--- FAIL: TestWorker (1.68s)
panic: 
	assert: mock: I don't know what to return because the method call was unexpected.
		Either do Mock.On("Resume").Return(...) first, or remove the Resume() call.
		This method was unexpected:
			Resume()
			
		at: [.../executor/dm/unitholder_test.go:309 .../executor/dm/worker.go:362 .../executor/dm/worker.go:174 .../executor/dm/worker_test.go:143] [recovered, repanicked]

goroutine 423 [running]:
testing.tRunner.func1.2({0xa884a00, 0xc002e2eb80})
	.../src/testing/testing.go:1872 +0x419
testing.tRunner.func1()
	.../src/testing/testing.go:1875 +0x683
panic({0xa884a00?, 0xc002e2eb80?})
	.../src/runtime/panic.go:783 +0x132
github..../stretchr/testify/mock.(*Mock).fail(0xc00265aea8, {0xb71cc3b, 0xc1}, {0xc002f8c500, 0x4, 0x4})
	.../pkg/mod/github.com/stretchr/testify@v1.10.0/mock/mock.go:349 +0x1ac
github..../stretchr/testify/mock.(*Mock).MethodCalled(0xc00265aea8, {0xd8f2eb3, 0x6}, {0x0, 0x0, 0x0})
	.../pkg/mod/github.com/stretchr/testify@v1.10.0/mock/mock.go:517 +0x9aa
github..../stretchr/testify/mock.(*Mock).Called(0xc00265aea8, {0x0, 0x0, 0x0})
	.../pkg/mod/github.com/stretchr/testify@v1.10.0/mock/mock.go:481 +0x192
github..../engine/executor/dm.(*mockUnitHolder).Resume(0xc00265aea0, {0xb577bbb?, 0x19?})
	.../executor/dm/unitholder_test.go:309 +0xa5
github..../engine/executor/dm.(*dmWorker).checkAndAutoResume(0xc0025d5980, {0xc61a1f8, 0x121c0040})
	.../executor/dm/worker.go:362 +0x878
github..../engine/executor/dm.(*dmWorker).Tick(0xc0025d5980, {0xc61a1f8, 0x121c0040})
	.../executor/dm/worker.go:174 +0x90
github..../engine/executor/dm.TestWorker(0xc001bd8e00)
	.../executor/dm/worker_test.go:143 +0xedf
testing.tRunner(0xc001bd8e00, 0xb7d0660)
	.../src/testing/testing.go:1934 +0x21d
created by testing.(*T).Run in goroutine 1
	.../src/testing/testing.go:1997 +0x9d3

View the full list of 2 ❄️ flaky test(s)

github.com/pingcap/tiflow/pkg/tcpserver::TestTCPServerTLSGrpc

Flake rate in main: 100.00% (Passed 0 times, Failed 1 times)

Stack Traces | 0s run time

=== RUN   TestTCPServerTLSGrpc
    tcp_server_test.go:150: 
        	Error Trace:	.../pkg/tcpserver/tcp_server_test.go:150
        	Error:      	Received unexpected error:
        	            	[CDC:ErrToTLSConfigFailed]generate tls config failed: could not read ca certificate: open .../integration_tests/_certificates/ca.pem: no such file or directory
        	            	github.com/pingcap/errors.(*Error).GenWithStackByArgs
        	            		.../pkg/mod/github.com/pingcap/errors@v0.11.5-0.20250523034308-74f78ae071ee/normalize.go:177
        	            	github..../tiflow/pkg/errors.WrapError
        	            		.../pkg/errors/helper.go:34
        	            	github..../tiflow/pkg/security.(*Credential).ToTLSConfigWithVerify
        	            		.../pkg/security/credential.go:104
        	            	github..../tiflow/pkg/tcpserver.wrapTLSListener
        	            		.../pkg/tcpserver/tcp_server.go:167
        	            	github..../tiflow/pkg/tcpserver.NewTCPServer
        	            		.../pkg/tcpserver/tcp_server.go:84
        	            	github..../tiflow/pkg/tcpserver.TestTCPServerTLSGrpc
        	            		.../pkg/tcpserver/tcp_server_test.go:149
        	            	testing.tRunner
        	            		.../src/testing/testing.go:1934
        	            	runtime.goexit
        	            		.../src/runtime/asm_amd64.s:1693
        	Test:       	TestTCPServerTLSGrpc
--- FAIL: TestTCPServerTLSGrpc (0.00s)

github.com/pingcap/tiflow/pkg/tcpserver::TestTCPServerTLSHTTP1

Flake rate in main: 100.00% (Passed 0 times, Failed 1 times)

Stack Traces | 0.01s run time

=== RUN   TestTCPServerTLSHTTP1
    tcp_server_test.go:77: 
        	Error Trace:	.../pkg/tcpserver/tcp_server_test.go:77
        	Error:      	Received unexpected error:
        	            	[CDC:ErrToTLSConfigFailed]generate tls config failed: could not read ca certificate: open .../integration_tests/_certificates/ca.pem: no such file or directory
        	            	github.com/pingcap/errors.(*Error).GenWithStackByArgs
        	            		.../pkg/mod/github.com/pingcap/errors@v0.11.5-0.20250523034308-74f78ae071ee/normalize.go:177
        	            	github..../tiflow/pkg/errors.WrapError
        	            		.../pkg/errors/helper.go:34
        	            	github..../tiflow/pkg/security.(*Credential).ToTLSConfigWithVerify
        	            		.../pkg/security/credential.go:104
        	            	github..../tiflow/pkg/tcpserver.wrapTLSListener
        	            		.../pkg/tcpserver/tcp_server.go:167
        	            	github..../tiflow/pkg/tcpserver.NewTCPServer
        	            		.../pkg/tcpserver/tcp_server.go:84
        	            	github..../tiflow/pkg/tcpserver.TestTCPServerTLSHTTP1
        	            		.../pkg/tcpserver/tcp_server_test.go:76
        	            	testing.tRunner
        	            		.../src/testing/testing.go:1934
        	            	runtime.goexit
        	            		.../src/runtime/asm_amd64.s:1693
        	Test:       	TestTCPServerTLSHTTP1
--- FAIL: TestTCPServerTLSHTTP1 (0.01s)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

hongyunyan · 2026-02-02T14:31:27Z

/test pull-verify

hongyunyan · 2026-02-02T15:21:41Z

/test pull-verify

ti-chi-bot · 2026-03-16T16:18:38Z

@hongyunyan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-verify	`e05b276`	link	true	`/test pull-verify`
pull-cdc-integration-kafka-test	`e05b276`	link	true	`/test pull-cdc-integration-kafka-test`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

update

61f5ac4

ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 2, 2026

ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2026

gemini-code-assist bot reviewed Feb 2, 2026

View reviewed changes

update

e05b276

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test#12511

test#12511
hongyunyan wants to merge 2 commits intomasterfrom
0202

hongyunyan commented Feb 2, 2026

Uh oh!

ti-chi-bot bot commented Feb 2, 2026

Uh oh!

gemini-code-assist bot commented Feb 2, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Feb 2, 2026

Uh oh!

ti-chi-bot bot commented Feb 2, 2026

Uh oh!

codecov bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

hongyunyan commented Feb 2, 2026

Uh oh!

hongyunyan commented Feb 2, 2026

Uh oh!

ti-chi-bot bot commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

hongyunyan commented Feb 2, 2026

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Uh oh!

ti-chi-bot bot commented Feb 2, 2026

Uh oh!

gemini-code-assist bot commented Feb 2, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Feb 2, 2026

Uh oh!

codecov bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 2 Tests Failed:

Uh oh!

hongyunyan commented Feb 2, 2026

Uh oh!

hongyunyan commented Feb 2, 2026

Uh oh!

ti-chi-bot bot commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov bot commented Feb 2, 2026 •

edited

Loading