*: update third-party dependencies#12560
Conversation
ti-chi-bot
bot
added
the
release-note
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs routine maintenance by updating the Go language version and a specific cryptographic dependency. These updates ensure the project benefits from the latest language features, performance improvements, and security patches, thereby enhancing overall system stability and reliability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
ti-chi-bot
bot
added
the
size/S
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates third-party dependencies, including bumping the Go version string and updating filippo.io/edwards25519. My review has identified a critical issue in the integration-test.Dockerfile where an invalid Go version is used, which will break the Docker build. I've also pointed out that the Go version specified in several go.mod files is not a valid Go language version and should be corrected to follow the standard format (e.g., go 1.22).
|
|
||
| # Download go into /usr/local dir. | ||
| ENV GOLANG_VERSION 1.25.6 | ||
| ENV GOLANG_VERSION 1.25.7 |
There was a problem hiding this comment.
The Go version 1.25.7 is not a valid Go version available for download from dl.google.com. This will cause the Docker build to fail with a 404 error. The previous version 1.25.6 was also invalid. Please use a valid Go version. For example, if you intend to use Go 1.22.5, you should change this to 1.22.5.
ENV GOLANG_VERSION 1.22.5
| module avro-checksum-sample | ||
|
|
||
| go 1.25.6 | ||
| go 1.25.7 |
There was a problem hiding this comment.
The go directive specifies the Go language version and should be a valid version like 1.21 or 1.22. The version 1.25.7 is not a valid Go language version, and the previous 1.25.6 was also invalid. While the go tool might tolerate this, it's incorrect and can cause issues with other tooling. Please use the major Go version you are targeting. Based on your dependencies, 1.22 seems appropriate.
| go 1.25.7 | |
| go 1.22 |
References
- The
godirective in ago.modfile must specify a valid Go language version (e.g., '1.21', '1.22'). This ensures compatibility and proper functioning of Go tooling.
| module canal-json-handle-key-only-example | ||
|
|
||
| go 1.25.6 | ||
| go 1.25.7 |
There was a problem hiding this comment.
The go directive specifies the Go language version and should be a valid version like 1.21 or 1.22. The version 1.25.7 is not a valid Go language version, and the previous 1.25.6 was also invalid. While the go tool might tolerate this, it's incorrect and can cause issues with other tooling. Please use the major Go version you are targeting. Based on your dependencies, 1.22 seems appropriate.
| go 1.25.7 | |
| go 1.22 |
References
- The
godirective in ago.modfile must specify a valid Go language version (e.g., '1.21', '1.22'). This ensures compatibility and proper functioning of Go tooling.
| module github.com/breezewish/checker | ||
|
|
||
| go 1.25.6 | ||
| go 1.25.7 |
There was a problem hiding this comment.
The go directive specifies the Go language version and should be a valid version like 1.21 or 1.22. The version 1.25.7 is not a valid Go language version, and the previous 1.25.6 was also invalid. While the go tool might tolerate this, it's incorrect and can cause issues with other tooling. Please use the major Go version you are targeting. Based on your dependencies, 1.22 seems appropriate.
| go 1.25.7 | |
| go 1.22 |
References
- The
godirective in ago.modfile must specify a valid Go language version (e.g., '1.21', '1.22'). This ensures compatibility and proper functioning of Go tooling.
tools/check/go.mod
Outdated
| module github.com/pingcap/tidb-cdc/_tools | ||
|
|
||
| go 1.25.6 | ||
| go 1.25.7 |
There was a problem hiding this comment.
The go directive specifies the Go language version and should be a valid version like 1.21 or 1.22. The version 1.25.7 is not a valid Go language version, and the previous 1.25.6 was also invalid. While the go tool might tolerate this, it's incorrect and can cause issues with other tooling. Please use the major Go version you are targeting. Based on your dependencies, 1.22 seems appropriate.
| go 1.25.7 | |
| go 1.22 |
References
- The
godirective in ago.modfile must specify a valid Go language version (e.g., '1.21', '1.22'). This ensures compatibility and proper functioning of Go tooling.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (57.2944%) is below the target coverage (60.0000%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #12560 +/- ##
================================================
+ Coverage 49.4757% 57.2944% +7.8186%
================================================
Files 486 524 +38
Lines 70677 69183 -1494
================================================
+ Hits 34968 39638 +4670
+ Misses 32951 26689 -6262
- Partials 2758 2856 +98 🚀 New features to boost your workflow:
|
|
/retest |
ti-chi-bot
bot
added
needs-1-more-lgtm
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, wlwilliamx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
ti-chi-bot
bot
added
the
needs-cherry-pick-release-8.5
|
/retest |
1 similar comment
|
/retest |
|
/test pull-verify |
ti-chi-bot
bot
added
size/L
|
/retest |
|
/test pull-unit-test-cdc |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
@wk989898: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
What problem does this PR solve?
Issue Number: close #12556
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note