Skip to content

fix(web,server): improve runtime error visibility in thread error banner#1202

Open
ecatuogno1 wants to merge 1 commit intopingdotgg:mainfrom
ecatuogno1:fix/error-banner-truncation
Open

fix(web,server): improve runtime error visibility in thread error banner#1202
ecatuogno1 wants to merge 1 commit intopingdotgg:mainfrom
ecatuogno1:fix/error-banner-truncation

Conversation

@ecatuogno1
Copy link

@ecatuogno1 ecatuogno1 commented Mar 19, 2026

Summary

  • Increase server-side runtime error truncation limit from 180 to 512 characters to preserve diagnostic detail
  • Expand UI error banner from line-clamp-3 to line-clamp-6 so longer error messages remain readable without dominating the viewport

Problem

Runtime errors (e.g. malformed local SKILL.md with invalid YAML frontmatter) are truncated twice: server-side to 180 chars, then UI-side to 3 lines via line-clamp-3. This makes errors like invalid YAML parsing failures nearly unreadable — the user has to take a screenshot fast before the banner disappears, and even then the text is cut off.

Test plan

  • Trigger a runtime error with a long message (e.g. malformed .agent/skills/.../SKILL.md)
  • Verify the error banner shows enough text to diagnose the issue (up to 6 lines)
  • Verify short errors still render cleanly without excess whitespace
  • Server tests pass (bun run test in apps/server)

Closes #1084

Note

Improve runtime error visibility in thread error banner

  • Expands the error description in ThreadErrorBanner from 3 to 6 visible lines before clamping.
  • Passes an explicit 512 character limit to truncateDetail for runtime.error activity messages in ProviderRuntimeIngestion.ts, replacing the previous default truncation length.

Macroscope summarized 86b53ae.

Runtime errors (e.g. malformed local SKILL.md) were truncated twice:
server-side to 180 chars, then UI-side to 3 lines via line-clamp-3.
This made errors like invalid YAML parsing failures nearly unreadable.

- Increase server-side runtime error truncation limit from 180 to 512
  characters to preserve diagnostic detail
- Expand UI error banner from line-clamp-3 to line-clamp-6 so longer
  error messages remain readable without dominating the viewport

Closes pingdotgg#1084

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 845f1ba6-5216-43fa-9993-e1b17981dd44

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

@github-actions github-actions bot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Mar 19, 2026
@binbandit
Copy link
Contributor

Is there a chance we can get an example image attached?

@ecatuogno1
Copy link
Author

@binbandit Here’s the repro screenshot from #1084 showing the current truncated error banner state that this PR is fixing.

This change keeps the same banner UI, but increases the visible clamp from 3 lines to 6 and preserves up to 512 chars server-side instead of 180, so the same error is much more readable.

Current truncated runtime error banner

@ecatuogno1
Copy link
Author

@binbandit Fresh after screenshot from this PR branch.

This is the expanded thread error banner with the same kind of long malformed-SKILL.md runtime error, so you can see the 6-line clamp / higher truncation limit effect directly.

After screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Malformed local SKILL.md causes unreadable thread failure and poor diagnostics

2 participants