Use more idiomatic Effect services and durations#2628
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Context.Servicefor server environment label command execution and updated tests to useLayer.mockplusassertinstead of module mocks/expect.Schema.TaggedErrorClassfor label command failures.Duration.Input/Durationinstead of millisecond-only fields.Why
This keeps command execution mockable through Effect layers, makes failures typed and structured, and moves timeout policies toward Effect's native duration primitives.
UI Changes
Not applicable.
Checklist
Note
Replace numeric millisecond timeouts and
nullreturns with EffectDurationandOptiontypesRunSshCommandOptionsandwaitForHttpReadywithDuration.Inputparameters; internal constants in tunnel.ts and command.ts are also converted toDurationvalues.string | nullreturns withOption<string>throughout ServerEnvironmentLabel.ts fornormalizeLabel,parseMachineInfoValue,readLinuxMachineInfo, and related helpers.ServerEnvironmentLabelinto an injectableServerEnvironmentLabelCommandRunnerservice, with a live layer backed byChildProcessSpawnerand a structuredServerEnvironmentLabelCommandErrortype.RunSshCommandOptions.timeoutMsis replaced bytimeout?: Duration.Input; callers passing a raw number must update to aDurationvalue.Macroscope summarized 6240442.