Skip to content

fix(ssh): fix support for remotes that use fnm #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soorria wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

fix(ssh): fix support for remotes that use fnm #2641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/ssh/src/tunnel.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,9 @@ describe("ssh tunnel scripts", () => {
assert.include(script, 'prepend_path_if_dir "$VOLTA_HOME/bin"');
assert.include(script, 'prepend_path_if_dir "$HOME/.asdf/shims"');
assert.include(script, 'prepend_path_if_dir "$HOME/.local/share/mise/shims"');
assert.include(script, 'eval "$(fnm env --use-on-cd --shell sh)"');
assert.include(script, 'eval "$(fnm env --shell bash)"');
assert.include(script, "fnm use --silent-if-unchanged");
assert.include(script, "fnm use default");
assert.include(script, 'prepend_path_if_dir "$HOME/.nodenv/shims"');
assert.include(script, 'NVM_DIR="$HOME/.nvm"');
assert.include(script, "nvm use --silent default");
Expand Down
3 changes: 2 additions & 1 deletion packages/ssh/src/tunnel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,8 @@ ensure_remote_node_path() {
prepend_path_if_dir "$FNM_DIR"
prepend_path_if_dir "$HOME/.fnm"
if ! command -v node >/dev/null 2>&1 && command -v fnm >/dev/null 2>&1; then
eval "$(fnm env --use-on-cd --shell sh)" >/dev/null 2>&1 || eval "$(fnm env --shell sh)" >/dev/null 2>&1 || true
eval "$(fnm env --shell bash)" >/dev/null 2>&1 || true
fnm use --silent-if-unchanged >/dev/null 2>&1 || fnm use default >/dev/null 2>&1 || true
fi

prepend_path_if_dir "$HOME/.nodenv/bin"
Expand Down
Loading