Skip to content

Sync main-xavier with upstream main #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
leonardoxr wants to merge 46 commits into
base: main
Choose a base branch
from

Merge upstream main into main-xavier

01a42b9
Select commit
Loading
Failed to load commit list.
Draft

Sync main-xavier with upstream main #2645

Merge upstream main into main-xavier
01a42b9
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Correctness Check completed May 11, 2026 in 4m 33s

2 issues identified (191 code objects reviewed).

• Merge Base: 447236d
• Head: 01a42b9

Details

✅ File Path Comments Posted
✅ README.md 0
➖ bun.lock
✅ oxlint-plugin-t3code/index.js 0
✅ oxlint-plugin-t3code/utils.js 0
✅ .oxlintrc.json 0
✅ apps/web/src/store.ts 0
❌ apps/web/src/lib/markdownPlainText.ts 2
✅ packages/shared/src/orchestration.ts 0
➖ apps/web/src/lib/markdownPlainText.test.ts
➖ apps/web/package.json
✅ apps/web/src/lib/assistantMessageCopy.ts 0
➖ apps/web/src/components/ChatMarkdown.test.tsx
➖ apps/web/src/lib/assistantMessageCopy.test.ts
✅ apps/web/src/components/chat/threadSearch.ts 0
➖ packages/shared/package.json
✅ apps/web/src/components/chat/ThreadSearchBar.tsx 0
➖ apps/web/src/components/chat/threadSearch.test.ts
✅ apps/server/tsconfig.json 0
✅ apps/web/src/types.ts 0
➖ apps/web/src/components/chat/ProposedPlanCard.test.tsx
✅ apps/web/src/components/chat/threadSearchHighlight.tsx 0
✅ oxlint-plugin-t3code/rules/no-inline-schema-compile.js 0
✅ apps/web/src/components/chat/ThreadSearchBar.browser.tsx 0
➖ apps/web/src/components/chat/threadSearchHighlight.test.tsx
✅ apps/server/src/orchestration/Services/QueuedFollowUpReactor.ts 0
➖ apps/web/src/localApi.test.ts
✅ apps/server/src/orchestration/Layers/QueuedFollowUpReactor.ts 0
✅ apps/web/src/components/chat/ComposerQueuedFollowUpsPanel.tsx 0
➖ apps/server/src/server.test.ts
➖ apps/server/src/orchestration/Layers/QueuedFollowUpReactor.test.ts
✅ packages/contracts/src/settings.ts 0
✅ apps/server/src/persistence/Services/ProjectionThreadQueuedFollowUps.ts 0
➖ oxlint-plugin-t3code/test/utils.ts
✅ apps/server/src/persistence/Layers/ProjectionThreadQueuedFollowUps.ts 0
✅ apps/server/src/orchestration/Normalizer.ts 0
✅ apps/server/src/persistence/Migrations/031_ProjectionThreadQueuedFollowUps.ts 0
✅ packages/contracts/src/baseSchemas.ts 0
✅ apps/server/src/persistence/Migrations.ts 0
✅ apps/server/src/orchestration/decider.ts 0
✅ apps/web/src/components/KeybindingsToast.browser.tsx 0
➖ apps/server/src/orchestration/projector.test.ts
➖ apps/desktop/src/settings/DesktopClientSettings.test.ts
✅ apps/web/src/components/ChatView.logic.ts 0
✅ apps/web/src/components/chat/MessagesTimeline.tsx 0
➖ apps/server/src/orchestration/commandInvariants.test.ts
✅ apps/server/src/orchestration/projector.ts 0
✅ apps/web/src/components/ChatMarkdown.tsx 0
✅ apps/web/src/components/ChatView.browser.tsx 0
➖ apps/server/src/orchestration/Layers/OrchestrationEngine.test.ts
➖ apps/server/src/orchestration/Layers/ProjectionPipeline.test.ts
➖ apps/web/src/composerDraftStore.test.ts
✅ apps/server/src/orchestration/Layers/OrchestrationEngine.ts 0
✅ apps/server/src/orchestration/Layers/ProjectionSnapshotQuery.ts 0
✅ apps/web/src/components/chat/MessagesTimeline.logic.ts 0
✅ apps/server/src/orchestration/Services/OrchestrationEngine.ts 0
➖ apps/server/integration/orchestrationEngine.integration.test.ts
➖ apps/server/src/orchestration/Layers/ProjectionSnapshotQuery.test.ts
✅ apps/web/src/components/chat/TerminalContextInlineChip.tsx 0
✅ apps/server/src/orchestration/Layers/ProjectionPipeline.ts 0
➖ apps/server/integration/OrchestrationEngineHarness.integration.ts
✅ packages/contracts/src/orchestration.ts 0
✅ apps/web/src/components/chat/ProposedPlanCard.tsx 0

Filtered Issues Details

apps/server/src/persistence/Layers/ProjectionThreadQueuedFollowUps.ts
  • line 142: The replaceByThreadId function at lines 139-159 performs a delete followed by multiple inserts without transaction wrapping. If the delete succeeds but any subsequent insertQueuedFollowUpRow call fails, the database will be left in an inconsistent state: the original follow-ups are deleted, but only a partial set of new follow-ups exist. This violates the atomicity semantics implied by "replace" - the operation should either fully succeed or leave the data unchanged. Consider wrapping the delete and inserts in a SQL transaction using SqlClient.withTransaction or similar. [ Failed validation ]
View more details on MacroscopeApp