Skip to content

Avoid rerendering suggested SSH host rows #3556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cursor wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Avoid rerendering suggested SSH host rows #3556

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
509ac3f
Avoid rerendering suggested SSH host rows
cursoragent Jun 25, 2026
0bab680
Compare discovered SSH row props by value
cursoragent Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions apps/web/src/components/settings/ConnectionsSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1561,7 +1561,22 @@ const DesktopSshHostRow = memo(function DesktopSshHostRow({
</div>
</div>
);
});
}, areDesktopSshHostRowPropsEqual);

function areDesktopSshHostRowPropsEqual(
previous: Readonly<DesktopSshHostRowProps>,
next: Readonly<DesktopSshHostRowProps>,
): boolean {
return (
previous.connectingHostAlias === next.connectingHostAlias &&
previous.onConnect === next.onConnect &&
previous.target.alias === next.target.alias &&
previous.target.hostname === next.target.hostname &&
previous.target.username === next.target.username &&
previous.target.port === next.target.port &&
previous.target.source === next.target.source
);
}

function CloudLinkSwitch({
checked,
Expand Down Expand Up @@ -2749,7 +2764,7 @@ export function ConnectionsSettings() {
key={`${target.alias}:${target.hostname}:${target.port ?? ""}`}
target={target}
connectingHostAlias={connectingSshHostAlias}
onConnect={(nextTarget) => void handleConnectSshHost(nextTarget)}
onConnect={handleConnectSshHost}
/>
))}
{hasLoadedDiscoveredSshHosts &&
Expand Down
Loading