Make process diagnostics parsing more idiomatic Effect#3583
Draft
cursor[bot] wants to merge 2 commits into
Draft
Make process diagnostics parsing more idiomatic Effect#3583cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Schema.fromJsonStringand per-record Schema parsing instead ofJSON.parseplus ad-hoc record traversal.Optionand keep the process-query timeout as aneffect/Duration.ProcessDiagnosticstests to useassertfrom@effect/vitestand added a mocked WindowsChildProcessSpawnertest for the Schema decoding path.Why
This keeps process diagnostics easier to test and maintain with native Effect primitives while preserving the existing behavior of skipping malformed Windows records instead of failing the whole diagnostics read.
UI Changes
Not applicable; server diagnostics/test-only behavior, no UI changes.
Checklist
Verification:
PATH="/home/ubuntu/.nvm/versions/node/v24.18.0/bin:$PATH" pnpm --dir apps/server run test src/diagnostics/ProcessDiagnostics.test.ts(7 tests passed)PATH="/home/ubuntu/.nvm/versions/node/v24.18.0/bin:$PATH" pnpm exec vp check(passed with existing warnings)PATH="/home/ubuntu/.nvm/versions/node/v24.18.0/bin:$PATH" pnpm exec vp run typecheck(passed)Note
Refactor Windows process diagnostics parsing to use Effect Schema
parseWindowsProcessRowswith schema-driven decoding viaWindowsProcessRecordandWindowsProcessJsonschemas in ProcessDiagnostics.ts.normalizeWindowsProcessRecordto validate PIDs, derive command fromCommandLineorName, default emptyStatusto'Live', clamp negative CPU%, and roundWorkingSetSize.Option.noneand are skipped silently; invalid JSON yields an empty array instead of throwing.PROCESS_QUERY_TIMEOUT_MSwith aDuration-based constant passed directly toEffect.timeoutOption.Statusvalues now default to'Live'; previously they would propagate as-is.Macroscope summarized 5b499fd.