Skip to content

fix(web): show pull request refresh feedback #6384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
t3-code wants to merge 1 commit into
base: main
Choose a base branch
from
+36 −6
Open

fix(web): show pull request refresh feedback #6384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 36 additions & 6 deletions apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,11 +531,38 @@ export function PullRequestDetailPanel({
// and at worst answer from it.
const invalidate = useAtomCommand(pullRequestEnvironment.invalidate, { reportFailure: false });
const [refreshToken, setRefreshToken] = useState(0);
const refreshFromHost = useCallback(async () => {
await invalidate({ environmentId, input: { reference } });
refreshDetail();
setRefreshToken((token) => token + 1);
}, [environmentId, invalidate, reference, refreshDetail]);
const refreshFromHost = useCallback(
async (showFeedback = false) => {
const toastId = showFeedback
? toastManager.add({
type: "loading",
title: "Refreshing pull request...",
})
: null;
const result = await invalidate({ environmentId, input: { reference } });
refreshDetail();
setRefreshToken((token) => token + 1);
if (toastId !== null) {
toastManager.update(
toastId,
result._tag === "Failure"
? {
type: "error",
title: "Could not refresh pull request",
description: readableFailure(
squashAtomCommandFailure(result),
"Try again in a moment.",
),
}
: {
type: "success",
title: "Pull request refreshed",
},
);
}
},
[environmentId, invalidate, reference, refreshDetail],
);
// A refresh asked for by the page: the detail, and through the token below, the diff with it.
const appliedForcedToken = useRef(forcedRefreshToken);
useEffect(() => {
Expand Down Expand Up @@ -1143,7 +1170,10 @@ export function PullRequestDetailPanel({
<MoreHorizontalIcon className="size-4" />
</MenuTrigger>
<MenuPopup align="end" side="bottom" className="min-w-72">
<MenuItem disabled={detailQuery.isPending} onClick={() => void refreshFromHost()}>
<MenuItem
disabled={detailQuery.isPending}
onClick={() => void refreshFromHost(true)}
>
<RefreshCwIcon className="size-3.5" />
Refresh
</MenuItem>
Expand Down
Loading