feat(git): support custom commit flags for app-run commits#977
feat(git): support custom commit flags for app-run commits#9770xnim wants to merge 16 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The worker errors seem to be pre existing |
|
Apologies, I never realized that was the reason you don't pr from main. I'll do it now. |
|
this is ready to go |
- Move extra commit args after message flags to avoid swallowing `-m` - Drop non-flag tokens when tokenizing user-supplied commit flags - Add tests and clarify the settings helper text
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Shows a yellow warning when non-flag tokens are entered (tokens not starting with a dash), matching the server-side sanitization behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Show a clear message about using = syntax instead of quotes, before falling through to the non-flag token check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update tokenizer to handle --flag="value with spaces" and --flag='value with spaces' syntax. Update client-side validation to match. Remove "not supported yet" disclaimer from UI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Keep the text generation and git commit flag controls compact - Remove the extra git commit flag help text - Simplify the reset button conditional formatting
|
@macroscope-app review this |

Related to #274.
What Changed
git commitflagsgit commitflags, so users can configure flags like--no-gpg-signWhy
T3 Code runs
git commitnon-interactively. On a machine with globalcommit.gpgsign=true, commits can fail because GPG prompts for a pass on/dev/tty, which does not exist in this case.This PR does NOT add interactive GPG/password support. Instead its a small workaround fix, users can configure extra commit flags for app run commits, which makes setups like
--no-gpg-signpossible without changing their global git configUI Changes
Adds a new Settings field under Git for extra git commit flags
Checklist
Note
Add custom git commit flags support via a new
gitCommitFlagsapp settinggitCommitFlagsstring setting (default empty) to app settings and a settings UI input that warns when non-flag tokens are detected.tokenizeCommitFlagsin GitManager.ts to parse and sanitize a raw flags string, filtering out non-flag tokens before forwarding togit commit.GitCore.commitand therunStackedActionpipeline to accept and pass through the sanitized extra flags array.GitRunStackedActionInputcontract schema is extended with an optionalcommitFlagsfield (max 4096 chars).Macroscope summarized b570ff5.