core: Add pingone-go-sdk-v2/management SDK for non-DaVinci PingOne resources - #132
Closed
samir-gandhi wants to merge 2 commits into
Closed
core: Add pingone-go-sdk-v2/management SDK for non-DaVinci PingOne resources#132samir-gandhi wants to merge 2 commits into
samir-gandhi wants to merge 2 commits into
Conversation
…sources pingone-go-client only covers DaVinci, Environments, Connectors, and ConfigurationManagement APIs, so the ~92 open Platform/SSO/Authorize/MFA/ Protect/Verify export-support issues cannot be implemented against it. Add patrickcping/pingone-go-sdk-v2/management (the SDK terraform-provider- pingone itself uses) as a second client on Client, built lazily since it performs an OAuth exchange at construction time rather than on first request.
Regression Test Results
✅ No regressions detectedAll export configurations produced compatible output. Generated by regression workflow • View run |
The go:embed directive listed pingone/base and pingone/davinci explicitly, so every new resource category (sso, platform, mfa, ...) would require editing this file — violating the "new resource requires zero edits to existing files" invariant. A single pingone/*/*.yaml wildcard covers any category subdirectory automatically.
Regression Test Results
✅ No regressions detectedAll export configurations produced compatible output. Generated by regression workflow • View run |
This was referenced Jul 26, 2026
Contributor
Author
|
Superseded by the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pingone-go-client, exposes just DaVinci, Environments, Connectors, and ConfigurationManagement APIs — none of the ~92 open export-support issues (resource/pingone_administrator_security: add export support #27-resource/pingone_verify_voice_phrase_content: add export support #118, tracked in PingOne Provider Coverage Tracker #119) for Platform/SSO/Authorize/MFA/Protect/Verify resources can be implemented against it.github.com/patrickcping/pingone-go-sdk-v2/management(the same SDKterraform-provider-pingoneuses) as a second client oninternal/platform/pingone.Client, alongside the existing DaVinci client — no existingresource_*.gofiles are touched.Client.management(ctx)becausepingonesdkv2.Config.ManagementAPIClient(ctx)performs an OAuth token exchange at construction time (unlike the DaVinci SDK, which defers auth to first request) — eager construction would breakNewFromCredentialsunit tests with fake credentials and make everyClientconstruction do a live network call.internal/platform/pingone/client_test.gofixtures to use UUID-shaped client/environment IDs, since the new SDK'sConfig.Validate()rejects non-UUID-shaped values (the old fixtures used placeholder strings like"client-123").This is prep work only — no new resources are added in this PR. It unblocks the pilot batch (
pingone_resource,pingone_population,pingone_group,pingone_application) which needs this client.Test plan
go build ./...go vet ./...go fmt ./...go test ./internal/... -count=1— all packages pass, includinginternal/platform/pingonewith updatedTestNewFromCredentialsfixturesManagementAPIClientauthenticates andResourcesApi.ReadAllResourcessucceeds against the target environment (not part of this diff, done to verify the wiring before handing off to resource-implementation agents)🤖 Generated with Claude Code