Skip to content

resource/pingone_application: add export support #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samir-gandhi wants to merge 3 commits into from
Closed

resource/pingone_application: add export support #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3670f4c
core: Add pingone-go-sdk-v2/management SDK for non-DaVinci PingOne re…
samir-gandhi Jul 24, 2026
b27c625
core: Generalize embed.go glob so new category directories need no edit
samir-gandhi Jul 26, 2026
56204e9
resource/pingone_application: Add export support
samir-gandhi Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/pr-137.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:new-resource
`resource/pingone_application`: Added export support for OIDC, SAML, External Link, and WS-Fed applications. The three built-in PingOne system application types (Admin Console, Portal, Self Service) have no corresponding Terraform schema block in `pingone_application` and are skipped with a warning rather than exported incorrectly.
```
12 changes: 6 additions & 6 deletions cmd/export_outputs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ import (

func TestParseOutputPath(t *testing.T) {
tests := []struct {
name string
raw string
wantOk bool
wantResType string
wantLabel string
wantAttrPath string
name string
raw string
wantOk bool
wantResType string
wantLabel string
wantAttrPath string
}{
{
name: "valid 3-segment path",
Expand Down
2 changes: 1 addition & 1 deletion contributing/RESOURCE_COVERAGE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Legend: ✅ Supported · ❌ Not yet supported

| Resource | Supported |
|---|---|
| `pingone_application` | ❌ |
| `pingone_application` | ✅ |
| `pingone_application_attribute_mapping` | ❌ |
| `pingone_application_flow_policy_assignment` | ❌ |
| `pingone_application_resource` | ❌ |
Expand Down
8 changes: 5 additions & 3 deletions definitions/embed.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ package definitions
import "embed"

// FS contains all embedded resource definition YAML files.
// The embed directive includes all .yaml files under pingone subdirectories.
// Subdirectories (base/, davinci/, etc.) are organizational only.
// The embed directive includes all .yaml files under any pingone category
// subdirectory (base/, davinci/, sso/, etc.) — subdirectories are
// organizational only. New category directories do not require editing this
// file.
//
//go:embed pingone/base/*.yaml pingone/davinci/*.yaml
//go:embed pingone/*/*.yaml
var FS embed.FS
Loading
Loading