Conversation
DarKhaos
force-pushed
the
I18N-1387
branch
2 times, most recently
from
July 20, 2026 22:45
2a2761d to
26dc97b
Compare
Summary Adds support for skipping i18n checks using a GitHub PR label in addition to the existing comment-based mechanism. PRs can now be labeled with skip-i18n-checks to bypass i18n validation checks without requiring a comment. Changes - Added --skip-i18n-checks-label parameter to GithubPRInfoCommand (defaults to skip-i18n-checks) - Modified check logic to support both label-based and comment-based skip mechanisms - Only adds reaction to comment when checks are skipped via comment (not via label) - Updated commit status message to reflect both skip methods - Added comprehensive test coverage for label-only and combined label+comment scenarios Test Plan - Unit tests added for label-based skip functionality - Tests verify correct behavior when both label and comment are present - Tests confirm reaction is only added to comments, not when label is used
maallen
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for skipping i18n checks using a GitHub PR label in addition to the existing comment-based mechanism. PRs can now be labeled with skip-i18n-checks to bypass i18n validation checks without requiring a comment.
Changes
Test Plan