Adding initial commit for the blocking functionality in the get func…#535
Open
JoJo10Smith wants to merge 4 commits intopinterest:masterfrom
Open
Adding initial commit for the blocking functionality in the get func…#535JoJo10Smith wants to merge 4 commits intopinterest:masterfrom
JoJo10Smith wants to merge 4 commits intopinterest:masterfrom
Conversation
… instead of max time and max attempts. Also cleaned up the function to try removing any that have idles for too long
…t we are checking agains if an object has been idling for too long
Author
|
I realized that there was a better implementation which I will explain below:
I look forward to hearing any feedback/ responding to questions In response to #519 |
jogo
requested changes
Nov 22, 2023
Contributor
jogo
left a comment
There was a problem hiding this comment.
thanks for the PR, a few inline comments and once those are sorted out better inline documentation, unit tests and updating the changelog would be great.
| self.release(obj) | ||
|
|
||
| def get(self): | ||
| def get(self, **options): |
Contributor
There was a problem hiding this comment.
Why not use keyword arguments with defaults here? That and a docstring will make this feature easier to find and documented in our code docs.
|
|
||
| if self._after_remove is not None: | ||
| self._after_remove(obj) | ||
| while current_time <= end_time: |
Contributor
There was a problem hiding this comment.
if I understand this correctly this results in busy waiting all while holding a lock. Which seems like a behavior we don't want to introduce.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add the blocking functionality to the get function with the following optional parameters:
This is in response to issue #519