Add contract claimability analysis script #178
Merged
fr1jo merged 5 commits intofrijo/release/PI-15from Feb 5, 2026
Merged
Conversation
fr1jo
approved these changes
Feb 4, 2026
fr1jo
approved these changes
Feb 4, 2026
Contributor
fr1jo
left a comment
fr1jo
left a comment
There was a problem hiding this comment.
simple logging additions, otherwise, lgtm!
| isUpgraded: upgrade.isUpgraded && upgrade.originalVersion && !isVersionClaimable(upgrade.originalVersion) | ||
| }); | ||
| } | ||
| } catch (e) {} |
Contributor
There was a problem hiding this comment.
can you just put a simple error log here saying that this failed.
why is this try catch? what happens if this fails?
| return v; | ||
| }, 2); | ||
| return { version, method: 'VERSION()' }; | ||
| } catch (e) {} |
Contributor
There was a problem hiding this comment.
simple error message here as well
Contributor
Author
There was a problem hiding this comment.
This catch is intentionally silent detectSafeVersion is called for every contract address, and VERSION() / getThreshold() are expected to fail on non-Safe contracts.
I refactored here to make more clear and added comments, here: 3cfdfb6
fr1jo
reviewed
Feb 4, 2026
| } | ||
| } | ||
|
|
||
| function parseVersion(version) { |
Contributor
There was a problem hiding this comment.
could you write a quick comment here on why we need to omit "-L2"
fr1jo
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.