Make refactored BWE compatible with the old API#308
Draft
mengelbart wants to merge 4 commits intomasterfrom
Draft
Make refactored BWE compatible with the old API#308mengelbart wants to merge 4 commits intomasterfrom
mengelbart wants to merge 4 commits intomasterfrom
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (60.70%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 71.38% 69.79% -1.60%
==========================================
Files 79 98 +19
Lines 4526 5340 +814
==========================================
+ Hits 3231 3727 +496
- Misses 1158 1469 +311
- Partials 137 144 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mengelbart
force-pushed
the
gcc-old-api
branch
from
9c58291 to
5f3f042
Compare
Member
|
Again I'm sorry about the conflicts, we had to ship the lint upgrades, Let me know, And I'll fix them for this branch :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes the refactored BWE implementation compatible with the existing
cc.Interceptorby implementing thecc.BandwidthEstimatorinterface and wrapping the newccfb.Interceptorin the oldcc.Interceptor. It does not (yet) implement pacing because that would cause nested pacing with the old implementation. Instead of merging this PR, I would actually prefer to remove the old API completely (by removing thegccandccpackages).