Open
Conversation
The tight coupling between RTPReader within interceptors prevents RTX packets from passing through the interceptors of the corresponding RTP track.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #317 +/- ##
==========================================
- Coverage 71.69% 69.82% -1.88%
==========================================
Files 79 79
Lines 4742 4752 +10
==========================================
- Hits 3400 3318 -82
- Misses 1203 1282 +79
- Partials 139 152 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 1/2 of a cross-repository series.
Part 2 : pion/webrtc#3064
Description
Replaced RTPReader with RTPprocessor.
Old
New
The tight coupling between RTPReader within interceptors prevents RTX packets from passing through the interceptors of the corresponding RTP track.
Reference issue
Fixes #3063