Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
==========================================
+ Coverage 78.67% 79.34% +0.67%
==========================================
Files 82 82
Lines 5106 4067 -1039
==========================================
- Hits 4017 3227 -790
+ Misses 919 667 -252
- Partials 170 173 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mengelbart
requested changes
Dec 1, 2025
| if ecnT, ok := e.(byte); ok { | ||
| ecn = rtcp.ECN(ecnT) | ||
| } else { | ||
| s.log.Error("ECN entry in attributes map is not of type byte") |
Contributor
There was a problem hiding this comment.
Maybe it is enough to log a warning?
| } | ||
|
|
||
| var ecn rtcp.ECN | ||
| if e, hasECN := attr["ECN"]; hasECN { |
Contributor
There was a problem hiding this comment.
I think the key could be a constant in attributes.go. Could you also use an int type to avoid the string comparison?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just updated
ecn's type fromuint8tortcp.ECNplus actually reading the ECN value from the interceptor attributes.