Replace GCC and deprecate gcc and cc packages#401
Draft
mengelbart wants to merge 1 commit intomasterfrom
Draft
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (35.29%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #401 +/- ##
==========================================
- Coverage 79.87% 78.92% -0.96%
==========================================
Files 88 75 -13
Lines 4581 4061 -520
==========================================
- Hits 3659 3205 -454
+ Misses 739 683 -56
+ Partials 183 173 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
39fc6a2 to
f5755aa
Compare
f5755aa to
5e399ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change replaces the GCC implementation with the improved version from pion/bwe. Since bandwidth estimation can be done without interceptors, the implementation no longer needs to be closely coupled with them as it was in the past.
This is a draft until pion/bwe#2 is merged and a bwe tag is released.