Skip to content

Replace GCC and deprecate gcc and cc packages#401

Draft
mengelbart wants to merge 1 commit intomasterfrom
feat/replace-gcc
Draft

Replace GCC and deprecate gcc and cc packages#401
mengelbart wants to merge 1 commit intomasterfrom
feat/replace-gcc

Conversation

@mengelbart
Copy link
Contributor

Description

This change replaces the GCC implementation with the improved version from pion/bwe. Since bandwidth estimation can be done without interceptors, the implementation no longer needs to be closely coupled with them as it was in the past.

This is a draft until pion/bwe#2 is merged and a bwe tag is released.

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 35.29412% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.92%. Comparing base (35588b3) to head (5e399ab).

Files with missing lines Patch % Lines
pkg/gcc/send_side_bwe.go 42.85% 22 Missing and 2 partials ⚠️
pkg/cc/interceptor.go 0.00% 9 Missing ⚠️

❌ Your patch check has failed because the patch coverage (35.29%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
- Coverage   79.87%   78.92%   -0.96%     
==========================================
  Files          88       75      -13     
  Lines        4581     4061     -520     
==========================================
- Hits         3659     3205     -454     
+ Misses        739      683      -56     
+ Partials      183      173      -10     
Flag Coverage Δ
go 78.92% <35.29%> (-0.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mengelbart mengelbart force-pushed the feat/replace-gcc branch 2 times, most recently from 39fc6a2 to f5755aa Compare February 4, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant