fix(pipedv1): use FindSlackGroups for group mentions in trigger-failed notification#6981
Open
Ahmad-Faraj wants to merge 1 commit into
Open
fix(pipedv1): use FindSlackGroups for group mentions in trigger-failed notification#6981Ahmad-Faraj wants to merge 1 commit into
Ahmad-Faraj wants to merge 1 commit into
Conversation
…d notification notifyDeploymentTriggerFailed assigns the groups list from FindSlackUsers, so configured Slack groups are never mentioned on trigger failure. The v0 piped counterpart uses FindSlackGroups here. Signed-off-by: Ahmad Faraj <ahmedfrag4040@gmail.com>
There was a problem hiding this comment.
Pull request overview
Fixes pipedv1 failed-trigger Slack notifications so configured Slack groups are mentioned correctly (matching the behavior already used for “deployment triggered” notifications and aligning with v0 piped behavior described in the PR).
Changes:
- Replace an incorrect
FindSlackUsers(...)call withFindSlackGroups(...)when populatingMentionedGroupsforEVENT_DEPLOYMENT_TRIGGER_FAILED.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
The failed-trigger notification in pipedv1 fills the group mentions by calling FindSlackUsers, so configured Slack groups are never mentioned when a trigger fails. Looks like a copy-paste from the line above. The v0 piped has it right. This switches it to FindSlackGroups.
Which issue(s) this PR fixes:
None
Does this PR introduce a user-facing change?: