fix: handle resourceUri in Open with File for explorer context menu#11
Open
eekwong wants to merge 1 commit into
Open
fix: handle resourceUri in Open with File for explorer context menu#11eekwong wants to merge 1 commit into
eekwong wants to merge 1 commit into
Conversation
When 'Pi: Open with File' is invoked from the explorer context menu, VS Code passes the selected file's URI as an argument. Previously this was ignored, so the command always fell back to the active editor and used the first workspace folder as cwd. Changes: - Accept resourceUri parameter in the openWithFile command handler - buildOpenWithFileContext() prefers the explicit resourceUri over the active editor, and resolves the correct workspace folder for the file - Return cwd alongside contextLines so the terminal starts in the matching workspace folder (important for multi-root workspaces) - createNewTerminal() accepts an optional cwd override
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When 'Pi: Open with File' is invoked from the explorer context menu, VS Code passes the selected file's URI as an argument. Previously this was ignored, so the command always fell back to the active editor and used the first workspace folder as cwd.
Changes: