Remove V2 finding compatibility for FixResult#1063
Merged
Conversation
gilday
approved these changes
May 21, 2025
| assert f.changeSets and f.changeSets[0].diff == v2changeset.diff | ||
| assert isinstance(f.finding, Finding) and f.changeSets[0].changes == [ | ||
| v2_finding_to_change[f.finding].to_common() | ||
| assert isinstance(f.finding, FindingV3) and f.changeSets[0].changes == [ |
Member
Author
There was a problem hiding this comment.
It's just an alias for the CodeTFv3 version of Finding
andrecsilva
approved these changes
May 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
drdavella
removed this pull request from the merge queue due to the queue being cleared
drdavella
force-pushed
the
remove-backwards-compatible-findings
branch
from
afd9a7f to
90d4d45
Compare
drdavella
force-pushed
the
remove-backwards-compatible-findings
branch
from
90d4d45 to
6589613
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead explicitly convert V2 findings into V3 findings where necessary. This simplifies some assumptions for consumers of
FixResult