Skip to content

fix(types): replace any types in dashboard profile page#321

Open
Nightkilller wants to merge 1 commit into
piyushdotcomm:mainfrom
Nightkilller:fix/profile-any-types
Open

fix(types): replace any types in dashboard profile page#321
Nightkilller wants to merge 1 commit into
piyushdotcomm:mainfrom
Nightkilller:fix/profile-any-types

Conversation

@Nightkilller
Copy link
Copy Markdown

@Nightkilller Nightkilller commented May 27, 2026

Description

Replaced any usages in app/dashboard/profile/page.tsx with explicit TypeScript types.

Changes Made

  • Imported and reused the existing Project type from @/modules/dashboard/types
  • Replaced (p: any) with (p: Project) in starred project filtering logic
  • Preserved existing component behavior and filtering functionality
  • Kept the implementation minimal and focused only on typing improvements

Fixes #292


Verification

  • Verified TypeScript compilation locally
  • Verified ESLint passes for the modified file
  • Confirmed no remaining any usages in the targeted section

Checklist

  • Minimal focused changes
  • No unrelated modifications
  • Existing functionality preserved
  • Type safety improved

Summary by CodeRabbit

  • Refactor
    • Enhanced type safety in profile management code.

Review Change Stack

@qodo-code-review
Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9345eb4f-de5f-4000-86e5-c8c7a0eded1a

📥 Commits

Reviewing files that changed from the base of the PR and between f12b223 and dc0285b.

📒 Files selected for processing (1)
  • app/dashboard/profile/page.tsx

Walkthrough

The PR replaces the any type annotation with an explicit Project type in the profile page's starred-projects filter. The Project type is imported from the dashboard types module and applied to the filter callback parameter.

Changes

Type Safety Improvement

Layer / File(s) Summary
Type annotation for starred projects filter
app/dashboard/profile/page.tsx
The Project type is imported and applied to the p parameter in the starred-projects filter predicate, replacing the any type annotation and ensuring the filtered projects list is properly typed.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🐰 A rabbit hops through the code with glee,
No more any—now types are clear to see!
The Project type joins the filter's dance,
Type safety wins with one small glance.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: replacing any types in the dashboard profile page with explicit TypeScript types.
Description check ✅ Passed The description covers the summary, changes made, and verification steps, though it diverges from the template structure with a custom format that still provides all necessary information.
Linked Issues check ✅ Passed The PR successfully addresses issue #292 by replacing any types with explicit Project types in the starred project filtering logic at the specified locations.
Out of Scope Changes check ✅ Passed All changes are directly related to the PR objective of replacing any types in app/dashboard/profile/page.tsx with explicit TypeScript types, with no out-of-scope modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

👋 Thanks for opening a PR, @Nightkilller!

Your PR has entered the 🚦 PR Review Pipeline.

Standard PR detected — your PR will follow the standard review pipeline.


What happens next

Stage Reviewer Checks
Stage 1 — Automated Validation 🤖 Bot DCO · Format · AI/Slop · Duplicate
Stage 2 — Human Review 👥 Maintainer Code + Quality Review
Stage 3 — PA / Maintainer Review 🔑 Project Admin Final Merge Decision

A pipeline status comment will appear below and update automatically as your PR progresses.


While you wait

  • Sign all commits (git commit -s)
  • Link your issue (Closes #123)
  • Use a feature branch (not main)
  • Avoid unrelated changes

This comment is posted only once.

@Maxd646 Maxd646 self-requested a review May 27, 2026 13:14
Copy link
Copy Markdown
Collaborator

@Maxd646 Maxd646 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for cleaning up those any types and improving the type safety of the profile page. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript: Replace any types in dashboard profile page

2 participants