feat: add Parallel.withTimeout(Duration) for per-task deadlines#23
Merged
feat: add Parallel.withTimeout(Duration) for per-task deadlines#23
Conversation
Returns a new Parallel that interrupts tasks exceeding the duration. A virtual thread timer fires the interrupt; the finally block cancels the timer if the task completes in time. Composes with withMaxConcurrency.
jimbao
approved these changes
Apr 22, 2026
jimbao
reviewed
May 1, 2026
Race condition: if Thread.sleep(timeout) returns naturally between task completion and the timer's interrupt call, the timer would interrupt a thread whose task already finished — polluting its interrupt flag for any subsequent blocking work on that thread. Fix: AtomicBoolean done flag. Timer checks it before interrupting; the finally block sets done=true before cancelling the timer.
jimbao
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per-task deadline that interrupts tasks exceeding the duration. A lightweight virtual thread timer fires the interrupt; it's cancelled if the task completes in time.
var parallel = Parallel.create(new GrpcContextPropagator())
.withMaxConcurrency(10)
.withTimeout(Duration.ofSeconds(5));
Composes with withMaxConcurrency. Applies to all operations (map, asMap, async, toEither). Complements gRPC deadlines — gRPC deadlines protect individual RPCs, withTimeout protects the overall task (which may
involve multiple RPCs, retries, etc.).
Test plan