feat: interrupt remaining tasks on failure in map() and asMap()#24
Draft
praveer-rai wants to merge 3 commits intomainfrom
Draft
feat: interrupt remaining tasks on failure in map() and asMap()#24praveer-rai wants to merge 3 commits intomainfrom
praveer-rai wants to merge 3 commits intomainfrom
Conversation
When a task fails, remaining virtual threads are now interrupted instead of left running in the background. This matches StructuredTaskScope semantics — fail fast and clean up. toEither/toEitherMap are unchanged since their contract is to run all tasks to completion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a task fails in map() or asMap(), remaining virtual threads are now interrupted instead of left running in the background. This matches StructuredTaskScope semantics — fail fast and clean up.
toEither and toEitherMap are unchanged — their contract is to run all tasks to completion and collect per-item results.
Internally, introduces a package-private Blockless.AsyncTask record that exposes the thread handle alongside the result supplier, enabling Parallel to interrupt threads on failure without changing any public API.
Test plan