Skip to content

Update button state also on change of URL or load #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5b5 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update button state also on change of URL or load #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
440c30f
Update button state also on change of URL or load
5b5 Aug 4, 2017
9a09844
iPhone X, iOS 11
5b5 Jan 16, 2018
a34c17a
updated podspec
5b5 Jan 16, 2018
3680b21
@objc hinzugefuegt
5b5 Mar 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PTPopupWebView.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

Pod::Spec.new do |s|
s.name = "PTPopupWebView"
s.version = "0.4.0"
s.version = "0.4.1"
s.summary = "Swift subclass of the UIView which provide Popup web view."
s.homepage = "https://github.com/pjocprac/PTPopupWebView.git"
s.license = 'MIT'
Expand Down
45 changes: 26 additions & 19 deletions Pod/Classes/PTPopupWebView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,27 @@ open class PTPopupWebView : UIView {
button.removeObserver(self, forKeyPath: "enabled")
}
}


fileprivate func updateButtonState() {
for i in 0 ..< buttonSettings.count {
let buttonSetting = buttonSettings[i]
switch buttonSetting.type {
case .back :
// To enable the Back button, when there is history.
buttons[i].isEnabled = webView.canGoBack
case .forward :
// To enable the Forward button, when there is advance history.
buttons[i].isEnabled = webView.canGoForward
case .reload :
// To enable the update button, after completion of reading.
buttons[i].isEnabled = webView.estimatedProgress == 1.0
default:
break
}
}
}


override open func observeValue(forKeyPath keyPath: String?, of object: Any?, change: [NSKeyValueChangeKey : Any]?, context: UnsafeMutableRawPointer?) {
if object is WKWebView {
if let keyPath = keyPath {
Expand All @@ -374,27 +394,13 @@ open class PTPopupWebView : UIView {
}
break;
case "URL":
updateButtonState()
break;
case "load":
updateButtonState()
break;
case "estimatedProgress":
for i in 0 ..< buttonSettings.count {
let buttonSetting = buttonSettings[i]
switch buttonSetting.type {
case .back :
// To enable the Back button, when there is history.
buttons[i].isEnabled = webView.canGoBack
case .forward :
// To enable the Forward button, when there is advance history.
buttons[i].isEnabled = webView.canGoForward
case .reload :
// To enable the update button, after completion of reading.
if let change = change, let progress = change[NSKeyValueChangeKey.newKey] as? Double {
buttons[i].isEnabled = progress == 1.0
}
default : break
}
}
updateButtonState()
break;
default:
break
Expand Down Expand Up @@ -469,7 +475,7 @@ open class PTPopupWebView : UIView {
}

/// Close popup view
open func close() {
@objc open func close() {
if let delegate = delegate {
// if delegate != nil (ex. when use PTPopupWebViewContoller)
delegate.close()
Expand All @@ -481,6 +487,7 @@ open class PTPopupWebView : UIView {
}


@objc
internal func buttonTapped (_ sender: AnyObject) {
if let button = sender as? UIButton, let index = buttons.index(of: button) {
if index < buttonSettings.count {
Expand Down
6 changes: 5 additions & 1 deletion Pod/Classes/PTPopupWebViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,13 @@ open class PTPopupWebViewController : UIViewController {
self.contentView.addSubview(popupView)

popupView.translatesAutoresizingMaskIntoConstraints = false
var borderItem :Any = contentView
if #available(iOS 11, *) {
borderItem = contentView.safeAreaLayoutGuide
}
for attribute in attributes {
let constraint = NSLayoutConstraint(
item : contentView, attribute: attribute, relatedBy: NSLayoutRelation.equal,
item : borderItem, attribute: attribute, relatedBy: NSLayoutRelation.equal,
toItem: popupView, attribute: attribute, multiplier: 1.0, constant: 0.0)
contentView.addConstraint(constraint)
constraints[attribute] = constraint
Expand Down