Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>
Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>
Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>
Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>
Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>
…4b50-93c4-0e11b13594f4 Clarify error handler ordering is correct - no changes needed
Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>
Co-authored-by: pladisdev <127021507+pladisdev@users.noreply.github.com>
…47b6-b204-5bf8892748d3 Extract magic numbers to named constants in audio playback code
…4606-8149-97ceaa22873d Use platform.system() instead of sys.platform for OS detection
Extract duplicated hex opacity calculation to utility function
Extract avatar active offset magic number into configurable setting
Fix audio reference cleanup on play() failure in popup mode
Fix race condition in popup avatar lifecycle
…into development
There was a problem hiding this comment.
Pull request overview
This PR refactors import structure for queue management, adds backward compatibility for settings, and includes defensive programming improvements. The main focus is moving queue-related imports from the main app module to a dedicated queue_manager module to improve code organization and prevent circular dependencies.
- Import refactoring: Moves
avatar_message_queueandparallel_message_queuefromapptomodules.queue_manageracross 12 import locations - Settings backward compatibility: Implements default settings merging to ensure new settings are available in older databases
- Defensive programming: Adds undefined check in frontend to prevent potential runtime errors
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/components/settings/GeneralSettings.jsx | Adds defensive undefined check before calling toString() on parallelMessageLimit |
| backend/version.py | Version bump from 1.3.0 to 1.3.1 |
| backend/routers/system.py | Updates import to get parallel_message_queue from queue_manager module |
| backend/routers/config_backup.py | Updates import to get avatar_message_queue from queue_manager module |
| backend/routers/avatars.py | Updates all avatar_message_queue imports across 11 locations to use queue_manager module |
| backend/modules/persistent_data.py | Implements default settings merging to ensure backward compatibility with older databases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| except Exception as e: | ||
| logger.error(f"Error loading settings: {e}") | ||
| return {} |
There was a problem hiding this comment.
The exception handler returns an empty dictionary instead of defaults, which is inconsistent with the logic on line 109 where defaults is returned when no settings are found. This could lead to missing default settings when an error occurs during settings loading. Consider returning defaults here as well to ensure fallback to default settings in all error cases.
✅ Windows Build SuccessfulExecutable: Build Status
Download the artifacts from the workflow run to test before merging. Once merged to |
🐳 Docker Image Built SuccessfullyImage: Test this PR with Docker:docker pull ghcr.io/pladisdev/chat-yapper:pr-7abefd2
docker run -d \
--name chat-yapper-pr \
-p 8069:8008 \
-e TWITCH_CLIENT_ID=your_id \
-e TWITCH_CLIENT_SECRET=your_secret \
ghcr.io/pladisdev/chat-yapper:pr-7abefd2Access at: http://localhost:8069 The Docker image will be published to the GitHub Container Registry when merged to |
No description provided.