Skip to content

Update "nonexistent times" appearance - #359

Open
mirmirmirr wants to merge 5 commits into
v0.4.7from
nonexistent-times
Open

Update "nonexistent times" appearance#359
mirmirmirr wants to merge 5 commits into
v0.4.7from
nonexistent-times

Conversation

@mirmirmirr

Copy link
Copy Markdown
Member

This pr updates the nonexistent times to be lighter and have a slight pattern, cursor-not-allowed was also added for more emphasis.

@mirmirmirr mirmirmirr added cleanup Involves refactoring or small changes frontend Related to frontend stuff labels Jun 25, 2026
Copilot AI review requested due to automatic review settings June 25, 2026 14:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@mirmirmirr mirmirmirr linked an issue Jun 25, 2026 that may be closed by this pull request
@mirmirmirr mirmirmirr added this to the v0.4.5 milestone Jun 25, 2026
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a196aa2d-5906-42b5-830b-4e6f95cbce8d

📥 Commits

Reviewing files that changed from the base of the PR and between 3ef5946 and 63bdbcb.

📒 Files selected for processing (1)
  • frontend/src/features/event/grid/timeblocks/base.tsx

📝 Walkthrough

Walkthrough

BaseTimeBlock now renders one background overlay per visible day column, spanning the full grid and applying a diagonal repeating linear gradient.

Changes

Per-day grid overlays

Layer / File(s) Summary
Overlay cell rendering
frontend/src/features/event/grid/timeblocks/base.tsx
BaseTimeBlock adds a loop that renders one full-height overlay cell per visible day with a repeating linear gradient background.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands.

@mirmirmirr
mirmirmirr requested a review from jzgom067 June 27, 2026 15:28
@jzgom067
jzgom067 changed the base branch from v0.4.5 to v0.4.6 June 29, 2026 17:38
@jzgom067 jzgom067 modified the milestones: v0.4.5, v0.4.6 Jun 29, 2026

@jzgom067 jzgom067 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing, when hovering a nonexistent timeslot it should clear the hovered timeslot. Currently, it keeps the last hovered one like the functionality we used to have.

@jzgom067 jzgom067 modified the milestones: v0.4.6, v0.4.7 Jul 20, 2026
@jzgom067
jzgom067 changed the base branch from v0.4.6 to v0.4.7 July 20, 2026 21:06
@mirmirmirr
mirmirmirr requested a review from jzgom067 August 1, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Involves refactoring or small changes frontend Related to frontend stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update "nonexistent times" appearance

3 participants