v0.4.6 - #384
Conversation
Add limits and inline style to TextInputField
Fix date selector trigger area
Add share menu to dashboard
Grid preview removal
Add relevant titles to time selectors
WalkthroughThe pull request updates Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
frontend/src/app/settings/(submenus)/page.tsx (1)
32-35: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winEnforce length validation on submit.
While
handleDefaultNameChangecorrectly updates the error state when the nickname is too long,applyDefaultNameproceeds with the API call even if the input is currently invalid. Add a validation check to block the submission and ensure invalid names aren't sent to the backend.🛡️ Proposed fix to block invalid submissions
const applyDefaultName = async () => { if (!isEditingDefaultName) return; + + if (defaultName.length > MAX_DEFAULT_NAME_LENGTH) { + setDefaultNameError(MESSAGES.ERROR_DEFAULT_NAME_LENGTH); + return; + } + setDefaultNameError(""); try { if (defaultName) {
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: bdc08592-d65e-407f-941b-b5f22c063fd4
📒 Files selected for processing (29)
frontend/src/app/(auth)/forgot-password/page.tsxfrontend/src/app/(auth)/login/page.tsxfrontend/src/app/(auth)/register/page.tsxfrontend/src/app/(auth)/reset-password/page.tsxfrontend/src/app/(event)/[event-code]/page-client.tsxfrontend/src/app/(event)/[event-code]/painting/page-client.tsxfrontend/src/app/settings/(submenus)/page.tsxfrontend/src/components/text-input-field.tsxfrontend/src/features/account/setting-dialogs/change-password/steps/change.tsxfrontend/src/features/account/setting-dialogs/change-password/steps/reset.tsxfrontend/src/features/account/setting-dialogs/delete-account.tsxfrontend/src/features/dashboard/components/copy-button.tsxfrontend/src/features/dashboard/components/event.tsxfrontend/src/features/dashboard/components/share-button.tsxfrontend/src/features/drawer/components/base.tsxfrontend/src/features/event/availability/constants.tsfrontend/src/features/event/availability/validate-data.tsfrontend/src/features/event/components/selectors/time.tsxfrontend/src/features/event/editor/date-range/selector.tsxfrontend/src/features/event/editor/editor.tsxfrontend/src/features/event/grid/grid.tsxfrontend/src/features/event/grid/index.tsfrontend/src/features/event/grid/preview-dialog.tsxfrontend/src/features/event/results/attendees/mobile-drawer.tsxfrontend/src/features/share-menu/content.tsxfrontend/src/features/share-menu/menu.tsxfrontend/src/features/system-feedback/dialog/components/base.tsxfrontend/src/features/version-history/data.tsfrontend/src/lib/messages.ts
💤 Files with no reviewable changes (4)
- frontend/src/features/event/grid/preview-dialog.tsx
- frontend/src/features/event/grid/index.ts
- frontend/src/features/event/grid/grid.tsx
- frontend/src/features/dashboard/components/copy-button.tsx
New minor version:
TextFieldInputlength limits