Open
Conversation
This improves the performance of the linker (opentripplanner#2170) considerably. Instead of examining all edges within a 1 km radius we now do this in a number of iterations, each time doubling the radius. Usually the first iteration suffices in a dense area.
Working on opentripplanner#2170 I found that removing these String.toLowerCase() calls gives a 10% speedup.
This reverts commit cf7de06.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements an iterative geographical search for the SimpleStreetSplitter. In a second commit I reduced the number of calls to String.toLowerCase() in the OSMWithTags class. Together these changes reduce the build time of the ile-de-france osm plus the stif gtfs file from 6.8 minutes to 3.5 minutes on my machine.
I could not observe any huge spikes in memory allocation, nor did I try to reduce that.