Skip to content

Feature realtime stats#5

Open
clinct wants to merge 12 commits intoplannerstack:plannerstack_production_no_fare_detailsfrom
Mtwili:feature-realtime-stats
Open

Feature realtime stats#5
clinct wants to merge 12 commits intoplannerstack:plannerstack_production_no_fare_detailsfrom
Mtwili:feature-realtime-stats

Conversation

@clinct
Copy link

@clinct clinct commented Jan 27, 2017

No description provided.

barslett and others added 11 commits January 19, 2017 23:53
This service requires proprietary fare_attributes.txt and fare_rules.txt brought to you by Bliksem Labs B.V.
{
    fares: {
        type: "dutch",
        currency: "EUR"
    }
}
OpenTripPlanner now fetches a random fare_attribute and assumes the entire feed is in this currency. It also ignores the build.config. Since the DutchFare table contains Distance Units in XXX currency it might (and thus: will) happen that XXX as currency ends up in the client.
@clinct
Copy link
Author

clinct commented Jan 27, 2017

Thanks @Mtwili ! I opened this pull-request to test it out on our testing-server.

@skinkie Indeed, I think two pull-requests should be created for this in the end towards the Opentripplanner Master: Dutch Fares and the RT endpoint. Sadly, a feature on the Opentripplanner Master currently conflicts with Dutch Fareservice (the fare details), bringing down the performance big time.

So for now I've opened this pull request on the Plannerstack branch that does NOT contain the Fare Details.

@clinct
Copy link
Author

clinct commented Jan 27, 2017

Superficially it seems to work with actual real data :)

@Mtwili It would be great if you could provide a short description of the added endpoints and their expected workings, that way it can be tested more easily.

@Mtwili
Copy link
Collaborator

Mtwili commented Jan 27, 2017

@clint Sure, it will be done today.

@clinct
Copy link
Author

clinct commented Jan 29, 2017

Thanks: I still want to check out the following:

  • Test impact on performance of planning requests (a brief glance over our standard test graphs did indicate some negative impact)
  • Check out CPU/ Mem graphs of test machine
  • Code review
    • How come src/client/images/agency_logo.png is checked in?
  • Check out the generated documentation

clinct pushed a commit that referenced this pull request Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants