Skip to content

Fix #72 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skinkie wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #72 #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/js/viz_components/mareydiagram.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,15 +718,18 @@ export default class MareyDiagram {

// Iterate over the shared sequence
for (let i = 0; i < referenceSequences.length; i += 1) {
// Filter out last stop of the sequence because it is not valid as "last stop"
const refSequence = referenceSequences[i].slice(0, -1);
const otherSequence = otherSequences[i].slice(0, -1);
const refSequence = referenceSequences[i];
const otherSequence = otherSequences[i];
const lastStopIndexTerm = otherSequence[otherSequence.length - 1];

// For each shared sequence, add the positions data of the current trip by mapping
// the distance relative to the last stop of the trip to the absolute distance
// in the reference journey pattern
const vehicleSequence = positions
.filter(({ lastStopIndex }) => otherSequence.includes(lastStopIndex))
// Filter out last stop of the sequence beyond the arrival / departure
.filter(({ distanceSinceLastStop, lastStopIndex }) =>
!(distanceSinceLastStop > 0 && lastStopIndex === lastStopIndexTerm))
.map(({ time, distanceSinceLastStop, lastStopIndex, status, prognosed }) => {
// Find the index of the last stop before the current position
// in the reference journey pattern
Expand Down