feat: ECS Support - #120
Merged
Merged
Conversation
marcopiraccini
changed the title
marcopiraccini
changed the title
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Two applications on one unauthenticated service, asserting a cross-tenant read returns only the caller's data and that an application ICC never registered fails closed with a 404 rather than reading as an empty tenant.
Records why tenancy is resolved from the URL, why AuthConfig.mode was removed, and the outstanding ICC and machinist work: the ECS provider is missing applyDeployment/applyService and stubs the skew-protection gateway methods, and ICC's registerWorkflowApp returns early without a service account token.
Reconciles this branch with the product decision that a user should set as little as possible: requiring an explicit ID would force every deployment ICC does not template (observe mode, desk) to hand-set an identity the deployer already knows. Falls back through PLT_APP_NAME to the package name, warning on a managed platform which ID was assumed.
marcopiraccini
force-pushed
the
ecs-support
branch
from
August 12, 2026 14:45
730fbbd to
2f1ef59
Compare
marcopiraccini
marked this pull request as ready for review
August 12, 2026 14:53
marcopiraccini
requested review from
ShogunPanda and
mcollina
and removed request for
mcollina
August 12, 2026 15:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ECS support to the service and client. ICC and machinist changes are not included, so nothing runs end to end on ECS yet.
One check for the Kubernetes service account token was answering three questions: can I authenticate, am I multi-tenant, and is ICC managing me. They coincide on Kubernetes but not on ECS, which has no identity yet still runs several ICC-managed applications. ECS deployments therefore collapsed to a single tenant, self-registered handlers at
localhost, and stamped their version aslocal.Each package gets a
platform.tsdetecting Kubernetes from the token and ECS fromECS_CONTAINER_METADATA_URI_V4, withisManagedPlatform()for the union. No flags: there is nothing likeisK8sorisEcsto set. The client keys the application ID, resolved version, and handler self-registration onisManagedPlatform(); only the Authorization header still keys on Kubernetes.The service replaces
AuthConfig.modewithk8s?andmultiTenant. The enum was read in one place where only'none'mattered, whileconfig.k8sdid the real gating, andWF_AUTH_MODE=api-keysilently rejected every request. Unauthenticated requests on a managed platform now resolve the tenant from the URL the client already sends; applications are registered by ICC and unknown ones rejected. Unmanaged deployments are unchanged.Also fixes an unresolved application leaving
request.appIdat0, which made an unknown application read as empty rather than a 404.