Skip to content

Fix RowBinary tuple encoding re-normalizing nested types #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −1
Open

Fix RowBinary tuple encoding re-normalizing nested types #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/ch/row_binary.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,9 @@ defmodule Ch.RowBinary do
end

def encode({:tuple, types}, values) when is_list(types) and is_list(values) do
encode_row(values, types)
# types were already normalized by encoding_type({:tuple, ts}); use the
# private encoder so we don't re-run encoding_types/1 on normalized types
_encode_row(values, types)
end

def encode({:tuple, types}, nil) when is_list(types) do
Expand Down
10 changes: 10 additions & 0 deletions test/ch/row_binary_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,16 @@ defmodule Ch.RowBinaryTest do
encode({:map, :string, :string}, [{"hello", "world"}])
end

test "tuple with normalized nested types round-trips" do
dt = ~U[2026-01-02 03:04:05.123Z]
encoded = IO.iodata_to_binary(encode_rows([[{dt}]], ["Tuple(DateTime64(3, 'UTC'))"]))
assert decode_rows(encoded, ["Tuple(DateTime64(3, 'UTC'))"]) == [[{dt}]]

time = ~T[03:04:05.123456]
encoded = IO.iodata_to_binary(encode_rows([[{time}]], ["Tuple(Time64(6))"]))
assert decode_rows(encoded, ["Tuple(Time64(6))"]) == [[{time}]]
end

test "nil" do
assert encode({:nullable, :string}, nil) == 1
assert encode(:string, nil) == 0
Expand Down