Open
Conversation
samwestmoreland
approved these changes
May 17, 2024
chrisnovakovic
approved these changes
Jun 10, 2024
Contributor
chrisnovakovic
left a comment
chrisnovakovic
left a comment
There was a problem hiding this comment.
Was just about to write this myself, thanks!
| Optional = true | ||
| Help = Build tags to pass to the Go compiler | ||
|
|
||
| [PluginConfig "experiment"] |
Contributor
There was a problem hiding this comment.
Would it be more "Please-like" for the enabled experiments to be a list (i.e. a repeatable config entry) which is then concatenated into a string with commas in _goexperiment_env?
build_defs/go.build_defs
Outdated
|
|
||
| def _goexperiment_env(): | ||
| """Returns the GOEXPERIMENT env var, or None if there isn't one.""" | ||
| return {"GOEXPERIMENT": CONFIG.GO.EXPERIMENT} if CONFIG.GO.EXPERIMENT else None |
Contributor
There was a problem hiding this comment.
If this were to return {} rather than None, the return value could unconditionally be concatenated with all instances of env parameters modified in this PR.
peterebden
force-pushed
the
goexperiment
branch
from
dedb9a5 to
0589e59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It'd be cool to be able to use this to play around with
rangefuncand similar things.