Stop registering upgrade steps in subtemplate settings#5
Merged
Conversation
An upgrade step's identity is its version number in metadata.xml, not its title. Recording the free-text title under [tool.plone.backend_addon.settings.subtemplates] was unused by any template and its value-based dedup was wrong for non-unique titles. Remove the registration call and the tests asserting it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upgrade_stepsubtemplate'spost_copyhookupgrade_step/README.mdbobtemplate.cfg(legacy) andpyproject.tomlsettingsWhy
Upgrade steps no longer need to be tracked in the addon's subtemplate settings. The hook still bumps the profile version and wires up the per-step ZCML include.
Test plan
tests/test_upgrade_step.pypassestests/test_legacy_compat.pypasses