Green, i18n-ready scaffolding + language subtemplate#7
Closed
MrTango wants to merge 1 commit into
Closed
Conversation
- generated tree is ruff-clean out of the box (isort config + import fixes, drop unused imports, no shell=True in locales/update.py) - ct tests honour global_allow=false; restapi service_for scans the package's own interfaces (+ manual entry) - i18n: MessageFactory in i18n.py (not __init__), zope_i18n_compile_mo_files in dev zope.conf + test layer, new language subtemplate for locale .po catalogs - fix behavior test to look up the real registered IBehavior name - zope-setup full version derived from the addon minor; copier invoked via sys.executable -m copier; track .pot, ignore only .mo - tests: e2e ruff-clean generation, subtemplate idempotency, version derivation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
force-single-line,order-by-type=false,lines-after-imports=2), import-order fixes, dropped unused imports, andlocales/update.pyrewritten withoutshell=True.global_allow=false(create parent container, assertallowedContentTypes());restapi_serviceservice_forscans the package's own interfaces (+<enter manually>)._MessageFactory ini18n.py(not__init__.py),zope_i18n_compile_mo_filesin devzope.confand the test layer, and a newlanguagesubtemplate that scaffolds a locale.pocatalog.IBehaviorname.zope-setupfull Plone version derived from the addon's minor in the composite; copier invoked viasys.executable -m copier; track.pot, ignore only.mo.Pairs with plone/plonecli#111 (declarative
applyspec consuming these templates).Test plan
uv run --extra dev pytest -m "not integration"— 332 passeduv run ruff check .— cleanlanguage, version derivation