Conversation
|
@wkbkhard thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
ale-rt
left a comment
ale-rt
left a comment
There was a problem hiding this comment.
This LGTM, thanks!
I would go on removing this attribute if it causes an error.
Anyway I believe it was added for some reason and we should actually take care of understanding the original problem.
I think @agitator can help.
If I am not wrong he added the attribute here in this commit:
896ed50
Also @polyester might have some interesting suggestion for us.
| _opener_markup_template = ( | ||
| u'<input id="navitem-{uid}" type="checkbox" class="opener" />' | ||
| u'<label for="navitem-{uid}" role="button" aria-label="{title}"></label>' # noqa: E 501 | ||
| u'<label for="navitem-{uid}" aria-label="{title}"></label>' # noqa: E 501 |
There was a problem hiding this comment.
The trailing # noqa: E 501 can be removed given the line is shorter than 80 chars now.
3 participants
I just fixed the w3c Error with the attribute role in label